-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds clarity to build model terminology (issue #714) #876
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sorry, included a github action workflow script by mistake, and removing it now. |
Signed-off-by: Tianyu Chen <[email protected]>
Well, had a pretty bad experience with git rebase, but made it work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these clarifications, these changes are a solid improvement.
I have a few minor requests and a couple of questions, LMK what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will hold off on making any changes, before we resolve the comment thread for the "steps".
Signed-off-by: Tianyu Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will update the description and remove the reverted changes.
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Tianyu Chen <[email protected]>
Signed-off-by: Mark Lodato <[email protected]>
Signed-off-by: Mark Lodato <[email protected]>
Signed-off-by: Mark Lodato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just pushed a few minor fixes, so another review by @joshuagl would be appreciated.
Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Mark Lodato <[email protected]>
In the build model section:
After this change for the terms mentioned in issue #714: