Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vsa support #777
feat: vsa support #777
Changes from 32 commits
7980fde
b5eb147
a25abe2
b90ede0
a3a573a
9704c97
2f76f12
2dc64f7
1f123f3
edde0a8
ead4e9b
13a74b5
610ef6f
944c9a6
2ef9a40
f0fedec
ad1b81d
f5362e5
5636d0a
fec61b1
8befbc6
7fb5bf9
fbe83fb
00fed87
e47312f
cba639f
ff1cf43
942d8bb
73c9884
0172a12
e27f99f
968a34d
519a928
b9c6de5
f3b63b7
e0919a8
23d8e33
bf38fb0
1ccec0e
92ce34e
f9a4b35
9b2554e
e452493
7813046
721eee5
719e118
311b211
e8ed9cc
3d6e498
9560d1a
21f5c3a
80b4cec
368e43c
d33cbc3
a71e44a
6aef931
8cf01ea
15e9019
9cd9553
891ffff
b145f36
701d13a
59deb51
4cf2972
475962b
a1068c4
9ad9097
9f25bde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a process for when we can remove the experimental flag?
Would it be sufficient to not have this flag but have a release candidate build, & get feedback and iterate before cutting a final release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove it when we're ready to merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG, once this leaves draft, can you remove it?