Xhtml visualization #497
Open
Xhtml visualization #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pri pridaní podpory XHTML som aj trochu refactorol vyberanie XSLT z internetu. Nie úplne všetky XHTML budú fungovať, ale ak sa niektorá používa iba na zobrazenie alebo podpisovanie, nemá v sebe také špeci fičúrky, ktoré by nefungovali. Logicky by nefungovala editácia podania. |
jsuchal
reviewed
Aug 29, 2024
Comment on lines
496
to
505
| filterIfExist(entries, e -> e.mediaDestination().equals("sign")); | ||
| filterIfExist(entries, e -> List.of("HTML", "XHTML").contains(e.destinationType())); | ||
| filterIfExist(entries, e -> e.mediaDestination().equals("view")); | ||
| filterIfExist(entries, e -> e.destinationType().equals("XHTML")); | ||
|
|
||
| if (entries.stream().filter(entry -> entry.mediaDesination().equals("sign")).count() > 0) | ||
| entries.removeIf(entry -> !entry.mediaDesination().equals("sign")); | ||
| filterIfExist(entries, e -> e.language().equals("sk")); | ||
| filterIfExist(entries, e -> e.language().equals("en")); | ||
|
|
||
| if (entries.stream().filter(entry -> entry.destinationType().equals("XHTML")).count() > 0) | ||
| entries.removeIf(entry -> !entry.destinationType().equals("XHTML")); | ||
|
|
||
| else if (entries.stream().filter(entry -> entry.destinationType().equals("HTML")).count() > 0) | ||
| entries.removeIf(entry -> !entry.destinationType().equals("HTML")); | ||
|
|
||
| else if (entries.stream().filter(entry -> entry.destinationType().equals("TXT")).count() > 0) | ||
| entries.removeIf(entry -> !entry.destinationType().equals("TXT")); | ||
|
|
||
| if (entries.stream().filter(entry -> entry.language().equals("sk")).count() > 0) | ||
| entries.removeIf(entry -> !entry.language().equals("sk")); | ||
|
|
||
| else if (entries.stream().filter(entry -> entry.language().equals("en")).count() > 0) | ||
| entries.removeIf(entry -> !entry.language().equals("en")); | ||
| return entries.stream().findFirst().orElse(null); | ||
| } |
There was a problem hiding this comment.
Toto pre mna je trosku zle citatelne kedze ta metoda "mutuje" entries. Predtym som videl, ze najprv sa hlada sign potom xhtml potom html a potom txt. Tu to nevidim.
There was a problem hiding this comment.
mne tam vadilo, že sa príliš veľa opakovalo. Rozumiem, že metódy, ktoré menia parametre sú nešťastné. Ako kompromis by som metóde filterIfExist dal return type entries a nebude meniť tie entries v parametri ale ich kópiu.
jsuchal
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.