Reserve single thread executor service for server #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chcem vidieť video! |
|
@jsuchal pre taký čistý e2e test potrebujem normálne nainštalovať package. Lokálne ale na macu neviem zbuildiť taký, ktorý by som potom aj vedel spustiť (problémy s podpismi). Tak potrebujem build z githubu: https://github.com/slovensko-digital/autogram/actions/runs/9935142762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zamýšľal som sa, prečo trvá tak dlho spustiť Autogram z extension a potom zobraziť SignigDialog. V mojej konfigurácii mám zapnuté všetky trusted listy, takže SignatureValidator o to viac pečie po spustení. A dnes mi nejako napadlo, či to nebude tým, že server zdieľa thread pool so SignatureValidatorom. Skúsil som dať teda serveru osobitný thread a zrazu API odpovedá aj hneď po spustení Autogramu 🥳
Navyše, 8 threadov pre validátor je veľa. Povedzme, že bežný PC má 8 threadov, tak toto ho celý upečie. 4 dávajú väčší zmysel.