Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp qualification checking in multiple badges scenario #468

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix timestamp qualification checking in multiple badges scenario #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/main/java/digital/slovensko/autogram/ui/gui/SignatureBadgeFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ private static HBox createMultipleBadges(SignatureQualification signatureQualifi

var simple = reports.getSimpleReport();
for (var timestamp : simple.getSignatureTimestamps(signatureId)) {
var isQualified = timestamp.getQualificationDetails() != null;
var isQualified = simple.getTimestampQualification(timestamp.getId()) == TimestampQualification.QTSA;
var isFailed = timestamp.getIndication() == Indication.TOTAL_FAILED
|| timestamp.getIndication() == Indication.FAILED;
var isIndeterminate = timestamp.getIndication() == Indication.INDETERMINATE;
Expand All @@ -152,16 +152,13 @@ private static HBox createMultipleBadges(SignatureQualification signatureQualifi
flowPane.getChildren().add(createInvalidBadge("Neplatná ČP"));

else if (isIndeterminate)
flowPane.getChildren().add(
createUnknownBadge("Neznáma ČP"));
flowPane.getChildren().add(createUnknownBadge("Neznáma ČP"));

else if (isQualified)
flowPane.getChildren().add(
createValidQualifiedBadge(simple.getTimestampQualification(timestamp.getId()).getReadable()));
flowPane.getChildren().add(createValidQualifiedBadge(simple.getTimestampQualification(timestamp.getId()).getReadable()));

else
flowPane.getChildren().add(
createUnknownBadge("Neznáma ČP"));
flowPane.getChildren().add(createUnknownBadge("Neznáma ČP"));
}

return new HBox(flowPane);
Expand Down
Loading