Fix ORSR forms standalone and API #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celuchmarek
changed the title
celuchmarek
commented
Jun 25, 2024
Comment on lines
+58
to
+59
| if (EFormUtils.isOrsrUri(identifier)) | ||
| embedUsedSchemas = true; |
There was a problem hiding this comment.
Ja by som to radšej takto overridol. Je tu riziko, že v ďalekej budúcnosti prejdú na referencie, ale v tom momente by aj tak prešli na data.gov.sk/slovensko.sk formuát, takže je to jedno.
jsuchal
reviewed
Jun 27, 2024
| xsltParams = EFormUtils.fillXsltParams(transformation, identifier, xsltParams); | ||
| if (!transformation.isEmpty() && transformation.charAt(0) == '\uFEFF') |
There was a problem hiding this comment.
Tieto vynimky mam pocit, ze nemame uplne pokryte v testoch a zacina sa to tu kopit. Vieme pridat aj nejaky test co overi, ze sa to vsetko nastavilo spravne?
There was a problem hiding this comment.
toto iba odstraňuje BOM zo začiatku stringu. Mali sme to na inom mieste, ale nie v API transformácii.
jsuchal
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.