issue201/port-je-obsadeny-dialog #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-vajs
commented
Oct 7, 2023
tomas-vajs
commented
- New dialog fxml for error port in use.
- Controller for new window
- Main window show moved into GUI.java
- New handling for error showErrorPortInUse
- server::stop now in separate event
- Usage of new exception after error while buildServer
- New exception for used port
|
Upozornujem ze nie som developer. Preto prosim analyzujte kod pozorne :) |
jsuchal
reviewed
Oct 11, 2023
jsuchal
reviewed
Oct 11, 2023
jsuchal
reviewed
Oct 11, 2023
src/main/resources/digital/slovensko/autogram/ui/gui/port-in-use-dialog.fxml
Outdated
Show resolved
Hide resolved
|
@jsuchal toto som skombinoval s odchytávaním všetkých exceptions. Ak je obsadený port, ukáže sa error a Autgram sa spustí "v obmedzenom režime" (čiže bez api), čo sa píše ja vo window title: 
|
jsuchal
reviewed
May 24, 2024
Comment on lines
+40
to
+42
| GUIUtils.startIconified(windowStage); | ||
|
|
||
| windowStage.setTitle("Autogram"); |
There was a problem hiding this comment.
Na toto treba davat mega bacha. Poradie tychto volani som mega debugoval, sa to spravalo inak na win/linux/macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.