MacOS: Option to skip TLS certificate creation for Safari #217
Conversation
|
Jo, to dáva zmysel. Čiže takto bude vedieť user nainštalovať Autogram cez brew a potom tým To s tým skip súborom je nejaký best practice? Ešte som to nevidel, ale zase nemám toľko skúseností, tak sa pýtam. To bude musieť user vytvoriť ten skip súbor predtým ako si ide inštalovať Autogram cez brew? |
|
Ano, asi idealne by bolo keby to generovanie certifikatov riesil instalator safari extensionu, ale zatial to mame takto nastavene. Skip subor je uplny hack, lebo kvoli "bezpecnosti" nema pristup ani ku env ani k nicomu inemu cez co by som vedel posunut info, ze ma preskocit ten krok. Nebude musiet nic urobit, vyriesi to za neho brew package https://slovensko-digital.slack.com/archives/C0564RNLT62/p1688645300083349?thread_ts=1683236585.047879&cid=C0564RNLT62 Alternativy ako toto vyriesit su
|
| @@ -93,7 +93,7 @@ | |||
|
|
|||
| { | |||
| "label": "MacOS: Send package for notarization", | |||
| "command": "xcrun notarytool submit --keychain-profile \"autogram\" --keychain $APPLE_KEYCHAIN_PATH --wait target/Autogram-*.pkg", | |||
| "command": "pkgutil --check-signature target/Autogram-*.pkg && xcrun notarytool submit --keychain-profile \"autogram\" --keychain $APPLE_KEYCHAIN_PATH --wait target/Autogram-*.pkg", | |||
There was a problem hiding this comment.
toto je aby to faillo co najskor pred tym nez sa robi upload
There was a problem hiding this comment.
a teda ide iba o comand vo vscode, ktory pouziva developer
| @@ -167,6 +167,7 @@ if [[ "$platform" == "mac" ]]; then | |||
| fi | |||
|
|
|||
| if [[ "$properties_mac_sign" == "1" ]]; then | |||
| export JPACKAGE_MAC_SIGN="1" | |||
There was a problem hiding this comment.
ano, jedine ine co by tam davalo zmysel je "$properties_mac_sign" ale to je tiez "1"
…digital#217) split out cert creation
Ked sa spusta instalacia cez brew, nemoze vyzadovat interakciu.
Pridavame teda spravanie, ze ak existuje subor
$HOME/Library/Application Support/Autogram/tls/skiptak sa vytvaranie preskocitakisto pridavame moznost spustit
Autogram.app/Contents/Resources/Scripts/create-cert.shktory to urobi v buducnosti ak by pouzivatel chcel pouzivat rozsirenie na safari