Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release checklist #215

Merged
merged 21 commits into from
Aug 1, 2023

Conversation

pomali
Copy link
Contributor

@pomali pomali commented Jul 4, 2023

  • pridavame RELEASE.md kde si vie kazdy precitat co chceme skontrolovat pred releaseom (mozno je to redundantne?)
  • pridavame issue template pre Release issue
  • automaticky sa vytvara pri workflowe package novy issue z Release template-u
  • pridavame smoke testy ktorymi vyskusame cez API podpisat rozne subory s pouzitim GUI ./mvnw test -Psmoke

@pomali
Copy link
Contributor Author

pomali commented Jul 12, 2023

pridal som testy ktorymi lahko vieme vyskusat to co je zapisane v openAPI server.yml, na pridanie dalsieho examplu staci pridat jeho nazov do SignHttpSmokeTest

image

postupne cez API test natlaci examples zo server.yml, pouzivatel ich podpise, a potom neskor mozeme overit ci ten podpis/obsah je spravny, zatial to iba zistuje ci to odpovedalo v spravnom formate

pre spustenie treba profil smoke ./mvnw test -Psmoke

@pomali pomali marked this pull request as ready for review July 12, 2023 14:29
@pomali pomali requested a review from a team as a code owner July 12, 2023 14:29
- [ ] funguje inštalácia na Windows cez stiahnutý .msi
- [ ] funguje spustenie v GUI móde
- [ ] funguje URL handler [autogram://go](autogram://go)
- [ ] funguje GUI otvoriť jeden súbor, ten sa zobrazí, viem ho podpísať, vytvorí sa podpísaný súbor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuto by som skusal cez /docs viac typov suborov, mozno @celuchmarek vie identifikovat take problematicke. Ja si pamatam, ze problem bol naposledy s tym xslt na velke subory a to by toto neodhalilo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja nevnimam tento checklist ako uplne pretestovanie, skor take, ze robis hociktory release tak toto chces urcite prejst aj ked je to iba nejaka minor zmena

- [ ] funguje spustenie v GUI móde
- [ ] funguje URL handler [autogram://go](autogram://go)
- [ ] funguje GUI otvoriť jeden súbor, ten sa zobrazí, viem ho podpísať, vytvorí sa podpísaný súbor
- [ ] funguje CLI `autogram --help`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] funguje CLI `autogram --help`
- [ ] funguje CLI `autogram --help`

@pomali
Copy link
Contributor Author

pomali commented Jul 21, 2023

prerobil som to na event release do samostatneho workflowu, aby by sa to nepustalo viackrat kvoli os matrix-u, ale neviem to otestovat lebo ten event sa neda odsimulovat mimo main-u

@pomali
Copy link
Contributor Author

pomali commented Aug 1, 2023

@jsuchal otestovane na forku, issue vytvara vpohode taketo https://github.com/pomali/autogram/issues jedina vec ktoru neviem otestovat je ci bude fungovat @slovensko-digital/autogram-release-team ako assignee (teoreticky by mal)

@jsuchal jsuchal merged commit 46554e0 into slovensko-digital:main Aug 1, 2023
3 checks passed
@jsuchal jsuchal deleted the release-checklist branch August 1, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants