Remove unnecessary macros from NTT-123-4567 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 9, 2024
hanno-becker
force-pushed
the
cleanup_ntt
branch
from
e0e1ea5
to
43b762e
Compare
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 9, 2024
See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 9, 2024
See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 12, 2024
See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 12, 2024
See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Sep 12, 2024
* conditionally compile asm Signed-off-by: Thing-han, Lim <[email protected]> * add license to new mk files Signed-off-by: Thing-han, Lim <[email protected]> * integrate the new build system to python script Signed-off-by: Thing-han, Lim <[email protected]> * format c files Signed-off-by: Thing-han, Lim <[email protected]> * fix __ASSEMBLER__ preprocessor Signed-off-by: Thing-han, Lim <[email protected]> * Move AArch64 ASM into asm/aarch64/*, rename OPT values Use OPT=AARCH64 at the toplevel to enable AArch64 optimizations. Refined (internal) configuration options, e.g. for switching between NTT implementations, to follow. Signed-off-by: Hanno Becker <[email protected]> * Update [i]NTT with cleaned up version See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]> * Use global optimization flag, use AArch64 ASM only on AArch64 system Signed-off-by: Hanno Becker <[email protected]> * fix set OPT in test script Signed-off-by: Thing-han, Lim <[email protected]> --------- Signed-off-by: Thing-han, Lim <[email protected]> Signed-off-by: Hanno Becker <[email protected]> Co-authored-by: Thing-han, Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.