Allow setting functional_only = False
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`config.constraints.functional_only` is a wrapper property around `model_latencies` and `model_functional_units`. However, previously it would only be supported to set `functional_only = True`, in which case both `model_latencies` and `model_functional_units` would be set to `False` -- attempting `functional_only = False`, in turn, would be silently ignored, which is certainly not desired. This commit modifies the `functional_only` setter to always set both `model_functional_units` and `model_latencies` to the negation of the value that's being specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.constraints.functional_onlyis a wrapper property aroundmodel_latenciesandmodel_functional_units. However, previously it would only be supported to setfunctional_only = True, in which case bothmodel_latenciesandmodel_functional_unitswould be set toFalse-- attemptingfunctional_only = False, in turn, would be silently ignored, which is certainly not desired.This commit modifies the
functional_onlysetter to always set bothmodel_functional_unitsandmodel_latenciesto the negation of the value that's being specified.