Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split heuristic performance estimation #67

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

mkannwischer
Copy link
Collaborator

Resolves #66

Still WIP. Still have to put this behind a config option and re-run all the optimization using the split heuristic.

@hanno-becker
Copy link
Collaborator

@mkannwischer Ready?

@mkannwischer
Copy link
Collaborator Author

No, not yet.

@mkannwischer mkannwischer marked this pull request as ready for review July 11, 2024 05:13
@mkannwischer
Copy link
Collaborator Author

I added a configuration option (split_heuristic_estimate_performance) defaulting to True.
I've verified now that the configuration option works fine for both False and True.

Maybe it is not required to re-run all the examples at this point.

@hanno-becker
Copy link
Collaborator

@mkannwischer Agree

@hanno-becker hanno-becker merged commit 6b061ca into main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimate performance of final code when using the split heuristic
2 participants