Skip to content

Commit

Permalink
fix: make test_cluster output always same IP address (PostHog#29054)
Browse files Browse the repository at this point in the history
  • Loading branch information
Daesgar authored Feb 21, 2025
1 parent 4135b07 commit 2b1ec99
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions posthog/clickhouse/test/test_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,19 @@ def test_mutation_runner_rejects_invalid_parameters() -> None:


def test_exception_summary(snapshot, cluster: ClickhouseCluster) -> None:
def replace_memory_addresses(value):
return re.sub(r"0x[0-9A-Fa-f]{16}", "0x0000000000000000", value)
def replace_memory_addresses_and_ips(value):
message = re.sub(r"0x[0-9A-Fa-f]{16}", "0x0000000000000000", value)
return re.sub(r"address='\d{1,3}.\d{1,3}.\d{1,3}.\d{1,3}'", "address='127.0.0.1'", message)

with pytest.raises(ExceptionGroup) as e:
cluster.map_all_hosts(Query("invalid query")).result()

assert replace_memory_addresses(e.value.message) == snapshot
assert replace_memory_addresses_and_ips(e.value.message) == snapshot

with pytest.raises(ExceptionGroup) as e:
cluster.map_all_hosts(Query("SELECT * FROM invalid_table_name")).result()

assert replace_memory_addresses(e.value.message) == snapshot
assert replace_memory_addresses_and_ips(e.value.message) == snapshot

with pytest.raises(ExceptionGroup) as e:

Expand All @@ -50,7 +51,7 @@ def explode(_):

cluster.map_all_hosts(explode).result()

assert e.value.message == snapshot
assert replace_memory_addresses_and_ips(e.value.message) == snapshot


def test_mutations(cluster: ClickhouseCluster) -> None:
Expand Down

0 comments on commit 2b1ec99

Please sign in to comment.