fix log level test #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the proper member function to filter incoming log records. This effectively inverts a log level check that was introduced in 641816f which e. g. prevented Info level messages from being logged at Info level whereas they showed up on Error level etc. Reported-by: @thomasjfox, @pevogam Signed-off-by: Philipp Gesang <[email protected]>
|
@cezarmathe could you look into this? |
dpc
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the proper member function to filter incoming log records.
This effectively inverts a log level check that was introduced in
641816f which e. g. prevented Info level messages from being
logged at Info level whereas they showed up on Error level etc.
Reported-by: @thomasjfox, @pevogam
Signed-off-by: Philipp Gesang [email protected]