Improve accessibility of tab widgets #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
force-pushed
the
tab-accessibility-fixes
branch
from
591319e to
b8cdd38
Compare
DataTriny
force-pushed
the
tab-accessibility-fixes
branch
2 times, most recently
from
4251448 to
359f428
Compare
DataTriny
force-pushed
the
tab-accessibility-fixes
branch
from
359f428 to
c9c97d9
Compare
|
I forgot to mention that testing with assistive technologies currently rely on this AccessKit PR as it improve selection events and implement the I haven't tested the Qt backend myself, only made sure unit tests pass. |
ogoffart
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly improve the accessibility of the
TabWidgetas well as the other tab widget implementation in the gallery example.There is one annoying issue left with the gallery example: since the sidebar also contain a label at the top, this label is the first element to get focus as far as AccessKit is concerned. I think this is due to the fact that
accessible-delegate-focusdoes not ignore non-focusable items when building AccessKit tree updates. It is not strictly linked to tab widgets so I'm not including the fix in this PR.Suggested Changelog entries:
AccessibleRole::TabPanel