Add standard gem for linting #925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
|
As I suspected before in #924, plain Rubocop will be better for the purposes of Slim. I just checked the Standard gem and it is not a great idea for a project like Slim with a history. I agree that code consistency and coding standards are good, maybe even opinionated and rigid ones as promoted by StandardRB, however it is easier to use them in new projects in contrast to older ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only add standard to the Gemfile.
To lint, run :
To lint and automatically fix, run :
Applying default code style
You can see there is a major code style difference.
An example PR applies all fixes : #926
GitHub Action
A GitHub Action exists in
.github/workflows/lint.ymlthat you can run.