Unified the FFI by eliminating public static inline functions #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the assumption that it does not declares a public interface of any kind, but rather defines pointers to functions when compiling.
A separate translation unit is now responsible for generating exports,
as recommended by section 6.7.4 of the ISO C standard
This completes the task in *include/chipmunk/chipmunk_ffi.h*:
// TODO: get rid of the reliance on static inlines.
// They make a mess for FFIs.
Legacy function pointers are still supported, though the use of
-DCHIPMUNK_LEGACY_FFI. An additional option in cmake makes it easy to
enable or disable this feature. Eventually, it can be removed completely.
ghost
changed the title
|
@samvv This fixes compilation errors with building chipmunk library, but the demos still have a compilation error. Do they need to be updated to the new API? |
ghost
mentioned this pull request
|
@andrewrk You're right, totally forgot to test it on the demos! I will look into it when I have the time. |
|
Just a minor feedback since this is already frozen since august: if someone still wants to see this added he or she will have to look into it, because I won't, unfortunately. |
ghost
mentioned this pull request
|
Found some time; see the new pull #139 for a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FFI no longer consists of function pointers, which makes it much easier to import them in other programs/languages. Public functions that were declared
static inlineare now justinlineand exported in a seperate translation unit, as recommended by section 6.7.4 of the ISO C standardSomething similar was already noted in include/chipmunk/chipmunk_ffi.h:
Legacy function pointers are still supported, though the use of
-DCHIPMUNK_LEGACY_FFI. An additional option in cmake makes it easy toenable or disable this feature. Eventually, it can be removed completely.
There were also a few inlude-directives in
src/that were inconsistent with some other files; I have changed them to what I thought they should be.Tested on Ubuntu 14.04 with GCC 4.8.2.