Use CGFloat as the float type if CP_USE_CGTYPES is set. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are equivalent C types still handled this way in Swift? I was hoping to try to cleanup and simplify the macro gobbledygook in chipmunk_types.h. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bridging this library into Swift, the stricter typing means that all the CGFloat values from UIKit have to be cast back and forth from cpFloat. With this change, cpFloat is typedefed CGFloat if CP_USE_CGTYPES is set, which means no casts are required. This should have no effect when used from C, as CGFloat should be either float or double depending on the same conditions as cpFloat uses.