Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the "other" gender #423

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Addition of the "other" gender #423

wants to merge 20 commits into from

Conversation

Norde
Copy link

@Norde Norde commented Dec 16, 2022

The de, en, es, fr and no locales have been updated and translated.
The locales pt and zu have just been updated with the English version.

The variable "user.statistic_profile_attributes" now takes the values "male", "female" and "other" instead of "true" and "false.
Scripts calendar.js and members.js from admin interface have been updated accordingly.

Add an "other" gender option
Add of "other" gender translation
Added translation of "other" gender
Added translation of "other" gender
Added translation of "other" gender
Added translation for "other" gender
Added translation for "other" gender
Added translation for "other" gender
Added translation for "other" gender following German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according German official rules (unbestimmt)
Added translation for "other" gender according English, French, German and Spanish actual official rules.
In the absence of appropriate language skills, the other languages "other" entry has been left untranslated.
Added the "other" gender option and updated the radio input values
Added translation for "other" gender
@sylvainbx
Copy link
Member

sylvainbx commented Dec 19, 2022

Have you tested your changes? I'm afraid this won't work... 😕

This is not as easy as this to add a new gender. First of all, you must consider that the database currently stores a boolean, so you must start by writing a rails migration that changes the data type of the gender column of the statistic_profiles table to a string, and translate the current true/false to man/woman. Then you have to handle all these new values in the ruby code (see for example str_gender which won't work anymore with a string). You'll have also to handle CSV import and Excel exports. You'll have to deal with the SSO, the user edition form, the statistics and maybe other parts in the code... I'll also expect that you write or update some automated tests for this feature to be merged.

Lastly, you don't have to translate all the languages, only English is expected, the other languages are handled by the crowdin platform and must not be translated manually because this will conflict with crowdin.

@Norde
Copy link
Author

Norde commented Dec 19, 2022

I'm really sorry about this crappy PR.
I will revise my copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants