You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up preamble.tex and common.tex (and related files) to remove unneeded and vestigial content (hopefully streamlining the preamble in the process, and making it easier to understand/maintain)
(!) If necessary, slides may need to be updated to e.g. remove superfluous code (e.g. the knitrout environment), potentially leading to merge conflicts
Collateral damage that's probably not hurting anything: All my editors are set up to remove trailing whitespaces and ensure files end with a newline because POSIX.
Special care needs to be taken that after removing seemingly unneeded code, the slides not only compile without error, but also look correct, which is not entirely possible to achieve programmatically (I think)
Next steps:
Validate that compiled slides still look ok
Consolidate preamble.tex / common.tex / lmu-lecture.sty (at least common.tex likely unneeded as contents can be added to preamble or .sty file?)
This is a reduced version of the full status check rendered for each
lecture repository.
It does not link to rendered PDF files and only produces markdown
tables, which allows it to be appended to a pull request. It serves as a
rough check to ensure that the PR does not cause major breakage.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals of this PR:
style
preamble.tex
andcommon.tex
(and related files) to remove unneeded and vestigial content (hopefully streamlining the preamble in the process, and making it easier to understand/maintain)knitrout
environment), potentially leading to merge conflictsCollateral damage that's probably not hurting anything: All my editors are set up to remove trailing whitespaces and ensure files end with a newline because POSIX.
Special care needs to be taken that after removing seemingly unneeded code, the slides not only compile without error, but also look correct, which is not entirely possible to achieve programmatically (I think)
Next steps:
preamble.tex
/common.tex
/lmu-lecture.sty
(at leastcommon.tex
likely unneeded as contents can be added to preamble or .sty file?)