[SID-1548] Configuration extension: share the configuration interface with React SDK #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7f66425
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7cbc19c3.docusaurus-slashid-login.pages.dev |
| Branch Preview URL: | https://sid-1548-configuration-exten.docusaurus-slashid-login.pages.dev |
jake-slashid
approved these changes
Feb 12, 2024
kaspermroz
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login theme will now accept an additional configuration parameter -
formConfiguration. This optional parameter accepts an object of the same shape as the props of the ConfigurationProvider.This will add extra flexibility and remove friction between the underlying React SDK and the docusaurus theme.
Testing
I published a beta version
@slashid/[email protected]to facilitate testing, so the most relevant test steps would be these:@slashid/[email protected])formConfigurationoption to see if various combinations still workLegacy configuration API has the extra fields to set up OIDC but they are no longer documented:
We still support them so that the theme does not break someones website if they update to the next minor version. If you pass the legacy options, the new
formConfigurationoption will be ignored.