Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for NCB20-847 #4

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Changes for NCB20-847 #4

merged 3 commits into from
Jan 8, 2024

Conversation

ssieng-slalom
Copy link
Contributor

Changes in the Pull Request:

  • Fix Text Overlapping with Footer on Main Page.
  • Add missing certifications section.
  • Implement round corner to bottom right of image.
  • Remove unused dependencies.

- Fix Text Overlapping with Footer on Main Page.
- Add missing certifications section.
- Implement round corner to bottom right of image.
- Remove unused dependencies.
- Fix Text Overlapping with Footer on Main Page.
- Add missing certifications section.
- Implement round corner to bottom right of image.
- Remove unused dependencies.
Copy link
Member

@amar-preet amar-preet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amar-preet
Copy link
Member

amar-preet commented Jan 8, 2024

NIT: can also remove .gcloudignore, amplify/.config, and .eslintcache

@ssieng-slalom
Copy link
Contributor Author

NIT: can also remove .gcloudignore, amplify/.config, and .eslintcache

I will take care of removing them in the next pull request.

@ssieng-slalom ssieng-slalom merged commit c929565 into master Jan 8, 2024
1 check passed
@amar-preet amar-preet deleted the NCB20-847 branch January 8, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants