Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #94

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Fix CI tests #94

merged 6 commits into from
Sep 4, 2024

Conversation

RemiLehe
Copy link
Contributor

@RemiLehe RemiLehe commented Aug 28, 2024

The CI tests are currently failing on the master branch of slaclab/lume-model:
https://github.com/slaclab/lume-model/commits/master/

This PR introduces several changes to fix the CI tests:

  • Use botorch<0.11:
    This is because botorch 0.11 is only compatible with Python>=3.10, while the CI runs on Python 3.9

  • Use keras<3:
    This is because the CI tests download keras 3 by default, while the .keras files saved in the lume-model repo (e.g. here) are not compatible with keras 3. (Presumably because they were created some time ago.)

  • Replace mamba build with conda mambabuild (which requires boa)

@RemiLehe RemiLehe changed the title Update default Python version to 3.10 Update default Python version from 3.9 to 3.10 Aug 28, 2024
@RemiLehe RemiLehe changed the title Update default Python version from 3.9 to 3.10 Fix CI tests Aug 29, 2024
@RemiLehe
Copy link
Contributor Author

RemiLehe commented Aug 29, 2024

Hm, this is strange:

  • the ubuntu CI tests pass now
  • the macOS CI tests do not pass. And I am unable to reproduce the problem locally (on a MacBook)

@RemiLehe
Copy link
Contributor Author

RemiLehe commented Sep 4, 2024

As discussed offline, I remove the MacOS tests for now.

@roussel-ryan roussel-ryan merged commit c4b2a18 into slaclab:master Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants