Add support for NetBSD #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @c0repwn3r to sign the Salesforce Inc. Contributor License Agreement. |
wadey
added
the
NeedsDecision
|
Thanks for the submission, we will test this out! |
|
I see a check failed - let me take a look at that and fix what it doesn't like. |
|
Try it again now, fixed those formatting issues. |
nbrownus
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (rudimentary) support for NetBSD. NetBSD is very similar to FreeBSD, so only minimal changes to the FreeBSD code were needed to make a functioning NetBSD binary as well. This code has been tested with a DN-generated config and some unsafe_routes and appears to work flawlessly. Glad to help with testing and changes as needed.