[cert-v2] support compressed P256 public keys #1262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackDoan
force-pushed
the
cert-v2-compressed-p256
branch
from
3162075 to
1be1b82
Compare
wadey
approved these changes
Nov 6, 2024
|
There are problems here wrt handshakes and how we send the pubkey over "early" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite it being clunky in Go, supporting both compressed and uncompressed P256 public keys can help us shave 32 bytes from P256 certs. This PR adds support for compressed keys, but does not yet expose it to users via nebula-cert.