Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TBSCertificate.SignWith to abstract out sources-of-signatures #1233

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Add TBSCertificate.SignWith to abstract out sources-of-signatures #1233

merged 4 commits into from
Oct 8, 2024

Conversation

JackDoanRivian
Copy link
Contributor

@JackDoanRivian JackDoanRivian commented Oct 3, 2024 •
edited
Loading

This can probably also be rebased onto cert-interface, but I haven't tried yet

@JackDoanRivian JackDoanRivian marked this pull request as ready for review October 3, 2024 14:45
JackDoanRivian
JackDoanRivian commented Oct 3, 2024
View reviewed changes
cert/sign.go Outdated Show resolved Hide resolved
nbrownus
nbrownus reviewed Oct 3, 2024
View reviewed changes
cert/sign.go Outdated Show resolved Hide resolved
@JackDoanRivian JackDoanRivian changed the title Add TBSCertificate.SignWithPredicate to abstract out sources-of-signa… Add TBSCertificate.SignWith to abstract out sources-of-signatures Oct 7, 2024
nbrownus
nbrownus reviewed Oct 8, 2024
View reviewed changes
cert/sign.go Outdated Show resolved Hide resolved
@nbrownus nbrownus merged commit 2747f32 into slackhq:cert-v2 Oct 8, 2024
7 of 9 checks passed
nbrownus pushed a commit that referenced this pull request Oct 11, 2024
@JackDoanRivian @nbrownus
Add TBSCertificate.SignWith to abstract out sources-of-signatures (#1233
af0b881 
)

* Add TBSCertificate.SignWith to abstract out sources-of-signatures

* consistent signatures

* eliminate SignPkcs11

* update comment
nbrownus pushed a commit that referenced this pull request Oct 24, 2024
@JackDoanRivian @nbrownus
Add TBSCertificate.SignWith to abstract out sources-of-signatures (#1233
cd9364f 
)

* Add TBSCertificate.SignWith to abstract out sources-of-signatures

* consistent signatures

* eliminate SignPkcs11

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrownus nbrownus nbrownus approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackDoanRivian @nbrownus