Cert interface #1212
Merged
Cert interface #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrownus
commented
Sep 6, 2024
nbrownus
commented
Sep 6, 2024
nbrownus
force-pushed
the
cert-interface
branch
2 times, most recently
from
64bf64b to
16914c4
Compare
nbrownus
commented
Sep 7, 2024
nbrownus
force-pushed
the
cert-interface
branch
from
16914c4 to
93c5a8c
Compare
nbrownus
force-pushed
the
cert-interface
branch
from
93c5a8c to
2626ff9
Compare
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 3, 2024
nbrownus
commented
Oct 4, 2024
nbrownus
commented
Oct 4, 2024
brad-defined
approved these changes
Oct 8, 2024
wadey
reviewed
Oct 10, 2024
| } | ||
| // MarshalPEM will return a PEM encoded representation of this certificate | ||
| // This is primarily the format stored on disk | ||
| MarshalPEM() ([]byte, error) |
There was a problem hiding this comment.
The other methods in cert are like Marshal...ToPem() and Unmarshal...FromPEM(). Should we normalize the naming one way or the other?
wadey
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lays the groundwork for v2 certificates, ipv6 in the overlay, and hopefully a more ergonomic
certlibrary. It does break ABI backwards compatibility for thecertpackage but should continue to function just fine with v1.9.4 and earlier versions.There are many open questions laid out as review comments here.
The next PR is #1216