Skip to content

Commit

Permalink
Prepare for release 0.24.2.
Browse files Browse the repository at this point in the history
  • Loading branch information
ZacSweers committed Jan 30, 2025
1 parent 8b7603d commit 0dfe624
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 10 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ Changelog
**Unreleased**
--------------

0.24.2
------

_2025-01-30_

- Fix loading of optional properties with defined default values.
- Update to Kotlin `2.1.10`.
- Build against KSP `2.1.10-1.0.29`.

0.24.1
------

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ POM_DEVELOPER_ID=slackhq
POM_DEVELOPER_NAME=Slack Technologies, Inc.
POM_DEVELOPER_URL=https://github.com/slackhq
POM_INCEPTION_YEAR=2022
VERSION_NAME=1.0.0-SNAPSHOT
VERSION_NAME=0.24.2
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jvmTarget = "17"
jewel = "0.27.0"
jna = "5.16.0"
kaml = "0.67.0"
kotlin = "2.1.0"
kotlin = "2.1.10"
kotlinx-serialization = "1.8.0"
ksp = "2.1.10-1.0.29"
kotlinPoet = "2.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ public class PropertyResolver(
blankBehavior: BlankBehavior = BlankBehavior.ERROR,
): Provider<String> {
return providerFor(key)
.let { defaultValue?.let { providers.provider { defaultValue } } ?: it }
.let { provider ->
defaultValue?.let { provider.orElse(providers.provider { defaultValue }) } ?: provider
}
.filter {
when (blankBehavior) {
BlankBehavior.FILTER -> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ internal abstract class BasicAptOptionsConfig : AptOptionsConfig {
configure<KaptExtension> {
arguments {
baseConfig.globalOptions(foundryProperties).forEach { (key, value) ->
logger.lifecycle("Adding kapt args to $path: $key=$value")
arg(key, value)
}
}
Expand Down Expand Up @@ -193,8 +194,8 @@ internal object AptOptionsConfigs {
object Dagger : BasicAptOptionsConfig() {
override val targetDependency: String = "dagger-compiler"

override fun globalOptions(foundryProperties: FoundryProperties): Map<String, String> =
foundryProperties.daggerOptions.getOrElse(DEFAULT_ARGS)
override fun globalOptions(properties: FoundryProperties): Map<String, String> =
properties.daggerOptions.getOrElse(DEFAULT_ARGS)

private val DEFAULT_ARGS =
mapOf(
Expand All @@ -214,7 +215,7 @@ internal object AptOptionsConfigs {
object Moshi : BasicAptOptionsConfig() {
override val targetDependency: String = "moshi-kotlin-codegen"

override fun globalOptions(foundryProperties: FoundryProperties): Map<String, String> =
override fun globalOptions(properties: FoundryProperties): Map<String, String> =
mapOf("moshi.generated" to "javax.annotation.Generated")
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -735,10 +735,14 @@ internal constructor(
*/
public val daggerOptions: Provider<Map<String, String>>
get() =
resolver.optionalStringProvider("foundry.dagger.options", defaultValue = "").map { value ->
if (value.isBlank()) return@map emptyMap<String, String>()
value.splitToSequence(',').associate { kv -> kv.trim().split('=').let { it[0] to it[1] } }
}
resolver
.optionalStringProvider(
key = "foundry.dagger.options",
blankBehavior = PropertyResolver.BlankBehavior.FILTER,
)
.map { value ->
value.splitToSequence(',').associate { kv -> kv.trim().split('=').let { it[0] to it[1] } }
}

/** Overrides the kotlin language version if present. */
public val kaptLanguageVersion: Provider<KotlinVersion>
Expand Down

0 comments on commit 0dfe624

Please sign in to comment.