Fix iOS 17.1+ issues when using PanModal for view controller containers #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @ppave to sign the Salesforce Inc. Contributor License Agreement. |
ppave
changed the title
|
please could we merge this change or there is a problem ? |
Ruuuuddyyy
approved these changes
Mar 14, 2024
Ruuuuddyyy
approved these changes
Mar 14, 2024
racechao
added a commit
to racechao/PanModal
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for iOS 17.1+ versions when using PanModal for view controller containers (UINavigationController, UIPageViewController, etc). In this case
containerViewinsidePanModalPresentationControlleris nil and it breaks the logic, and as a result the bottom sheet is not displayed.As we show bottom sheets, I think we always should have a presenting view controller.
So the solution is to pass a source view controller in case of presenting view controller is not determined by OS.
Please note that there are cases when presenting view controller != source view controller, but I think for the case of this library it doesn't make much difference.
Tested on iPhone and iPad running on iOS 17.2.
Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.