Remove appearance transitions called on presenting controller #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This better mimics how iOS handles `overFullScreen`/`overCurrentContext`/`pageSheet` style presentations where—since the presenting view controller is remaining visible and part of the view hierarchy—it does not call `view*Appear`/`view*Disappear` methods
kylehickinson
force-pushed
the
remove-presenting-appearance-transitions
branch
from
d127e7e
to
32fc8b5
Compare
|
Wouldn't be easier just to introduce a flag to |
|
@kylehickinson @m1entus I did merge this in my fork: https://github.com/ppamorim/PanModal Feel free to test. |
ykozlovFivePro
approved these changes
Nov 1, 2022
ykozlovFivePro
approved these changes
Nov 1, 2022
mohammedbadr2
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #139
This better mimics how iOS handles
overFullScreen/overCurrentContext/pageSheetstyle presentations where—since the presenting view controller is remaining visible and part of the view hierarchy—it does not callview*Appear/view*DisappearmethodsUltimately this is a behaviour breaking change though for anyone consuming the code and relying on the presenting controller getting appearance transition calls
Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.