Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegate to check if pan gesture should begin #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienvieira
Copy link

Summary

This change allows to control if the pan gesture should begin or not. This is particularly important when your table view supports drag and drop or swipe to delete, since the pan gesture will conflict with the other table view gestures/touches.

The current delegate function func shouldRespond(to panModalGestureRecognizer: UIPanGestureRecognizer) -> Bool it is not enough to manage the pan gesture, because it's called too late during the gesture handling process.

Related issue/question:
#82

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • I've read and agree to the Code of Conduct.

  • I've written tests to cover the new code and functionality included in this PR.

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Damien Vieira seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Roach
Copy link

Roach commented Feb 19, 2021

@damienvieira would you mind signing the CLA when you have a chance?

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants