-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to choose background interaction mode (.dismiss / .forward or .none) #115
base: master
Are you sure you want to change the base?
Conversation
Ilya Kharlamov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I really look forward to have this functionality! |
Please, could someone with write access review this PR? I have stopped using this library because of this issue. @jordanpichler @ste57 @TosinAF @Marcocanc |
Hi guys, Do we have a plan to merge it? |
Works really well! 💯 Hope it gets merged soon |
Still not yet being merged? |
Summary
Related issue - #100
Now you can choose one of background interaction modes:
.dismiss
- Taps dismiss the modal immediately.forward
- Touches are forwarded to the lower window (In most cases it would be the application main window that will handle it.none
- Absorbs touches. The modal does nothing (Swallows the touch)Example:
I think now option
allowsTapToDismiss
can be marked as deprecated.Requirements (place an
x
in each[ ]
)I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.