Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to choose inset and visiablity for scroll view #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sc4pego4t
Copy link

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

  • [x ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [ x] I've read and agree to the Code of Conduct.

  • [x ] I've written tests to cover the new code and functionality included in this PR.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Andrey Gluhih seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@galandezzz galandezzz deleted the add_ability_to_choose_inset_and_indicator_visiability_for_scroll_view branch July 15, 2020 07:54
@RuiAAPeres
Copy link

Any update regarding this PR? ❤️

@Sc4pego4t
Copy link
Author

yeah, I'm sorry, struggling with CLA signing. As I understood I should add commit with my email?

@Sc4pego4t
Copy link
Author

image

this page seems broken, I can't find any accept button(

@Sc4pego4t
Copy link
Author

image

What do you think can be a source of my problem with CLA? btw i see it in my setting in authorised apps

@AivarasGus
Copy link

I accidentally came across the same issue and this PR would come in really handy. @Sc4pego4t I'm rooting for you to get this merged 🙏

@Sc4pego4t
Copy link
Author

@ste57 can you please help me? I've accepted policies, but merging is still blocked

/**
The inset for scroll view which will override default one (bottomLayoutGuide.height)

Default value is true.
Copy link

@AivarasGus AivarasGus Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be true. bottomLayoutGuide.length is probably what it should be

Suggested change
Default value is true.
Default value is bottomLayoutGuide.length.

@simdani
Copy link
Contributor

simdani commented Nov 4, 2020

@AivarasGus @Sc4pego4t @ste57 created same pr with additional properties for tests and with license stuff fixed #121 if it's not possible to sign this one we can merge mine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants