Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health: move away from setup.py #1623

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

WilliamBergamin
Copy link
Contributor

Summary

In this project we are using 3 configuration files, the pyprojet.toml a setup.cfg and a setup.py. This PR aims to simplify the projects configuration files by removing setup.py its logic was moved inside the ./scripts/ folder

These changes aim to map the behavior found around setup.py to the bash script format. The behavior of code generation and CI testing can be improved in follow up PRs.

Testing

N/A

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)
  • other

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality tests M-T: Testing work only labels Dec 23, 2024
@WilliamBergamin WilliamBergamin self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (241db14) to head (cb0066f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1623   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         113      113           
  Lines       12661    12661           
=======================================
  Hits        10766    10766           
  Misses       1895     1895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added this to the 3.34.1 milestone Dec 23, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for improving this!

@seratch seratch merged commit 7b04d01 into slackapi:main Dec 23, 2024
13 checks passed
@WilliamBergamin WilliamBergamin deleted the simplify-configue-file branch December 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants