chore: improve flaky tests #1615
Merged
+85
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
+ Coverage 84.89% 85.01% +0.11%
==========================================
Files 113 113
Lines 12639 12639
==========================================
+ Hits 10730 10745 +15
+ Misses 1909 1894 -15 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
commented
Dec 13, 2024
| # running Task gets suspended, and the event loop executes the next Task. | ||
| # To schedule a callback from another OS thread, the loop.call_soon_threadsafe() method should be used. | ||
| # https://docs.python.org/3/library/asyncio-dev.html#asyncio-multithreading | ||
| test.loop.call_soon_threadsafe(test.loop.stop) |
There was a problem hiding this comment.
I believe this line is creating more stability; taken from bolt-python
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to improve flaky tests in our CI pipeline and consolidate the mock socket mode clients found in this project
Testing
Ran the Ci pipeline a few times did not observe any flaking tests
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.