Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support python 3.13 #1614

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR aims to add official support for python 3.13

Testing

Unit tests pass locally 🟢
Manually tested basic apps 🟢

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality semver:patch Version: 3x labels Dec 13, 2024
@WilliamBergamin WilliamBergamin added this to the 3.33.6 milestone Dec 13, 2024
@WilliamBergamin WilliamBergamin self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (5c57a32) to head (bae8e8a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   84.89%   84.89%   -0.01%     
==========================================
  Files         113      113              
  Lines       12639    12661      +22     
==========================================
+ Hits        10730    10748      +18     
- Misses       1909     1913       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁 🐍 Nice changes in addition to the added version! LGTM and I left one question that's no blocker at all.

token: ${{ secrets.CODECOV_TOKEN }}
# python setup.py validate generates the coverage file
files: ./coverage.xml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Always appreciating formatting finds!

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seratch seratch merged commit 99744b9 into slackapi:main Dec 13, 2024
13 checks passed
@WilliamBergamin WilliamBergamin deleted the support_pthon_3_13 branch December 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor Version: 3x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants