Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit two websocket_client/websockets tests due to their instability on GitHub Actions #1493

Merged
merged 1 commit into from
May 3, 2024
Merged

Omit two websocket_client/websockets tests due to their instability on GitHub Actions #1493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
env:
PYTHON_SLACK_SDK_MOCK_SERVER_MODE: 'threading'
CI_LARGE_SOCKET_MODE_PAYLOAD_TESTING_DISABLED: '1'
CI_UNSTABLE_TESTS_SKIP_ENABLED: '1'
FORCE_COLOR: '1'
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 0 additions & 6 deletions tests/slack_sdk/socket_mode/test_interactions_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

from slack_sdk import WebClient
from slack_sdk.socket_mode import SocketModeClient
from tests.helpers import is_ci_unstable_test_skip_enabled
from tests.slack_sdk.socket_mode.mock_socket_mode_server import (
start_socket_mode_server,
socket_mode_envelopes,
Expand Down Expand Up @@ -48,9 +47,6 @@ def test_buffer_size_validation(self):
pass

def test_interactions(self):
if is_ci_unstable_test_skip_enabled():
return

default_recursion_limit = sys.getrecursionlimit() # will restore later
# This built-in WebSocket client internally has recursive method calls of _fetch_messages method.
# In this test, the method calls can result in the following error when giving a quite small buffer size.
Expand Down Expand Up @@ -135,8 +131,6 @@ def socket_mode_request_handler(client: BaseSocketModeClient, request: SocketMod
self.logger.info(f"Passed with buffer size: {buffer_size_list}")

def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server(self, 3011))
t.daemon = True
t.start()
Expand Down
3 changes: 1 addition & 2 deletions tests/slack_sdk/socket_mode/test_interactions_websocket_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ def tearDown(self):
cleanup_mock_web_api_server(self)

def test_interactions(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server(self, 3012))
t.daemon = True
t.start()
Expand Down Expand Up @@ -100,6 +98,7 @@ def socket_mode_request_handler(client: BaseSocketModeClient, request: SocketMod

def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
# this test tends to fail on the GitHub Actions platform
return
t = Thread(target=start_socket_mode_server(self, 3012))
t.daemon = True
Expand Down
7 changes: 0 additions & 7 deletions tests/slack_sdk_async/socket_mode/test_interactions_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

from slack_sdk.socket_mode.aiohttp import SocketModeClient
from slack_sdk.web.async_client import AsyncWebClient
from tests.helpers import is_ci_unstable_test_skip_enabled
from tests.slack_sdk.socket_mode.mock_socket_mode_server import (
start_socket_mode_server,
start_socket_mode_server_with_disconnection,
Expand Down Expand Up @@ -44,8 +43,6 @@ def tearDown(self):

@async_test
async def test_interactions(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server(self, 3001))
t.daemon = True
t.start()
Expand Down Expand Up @@ -108,8 +105,6 @@ async def socket_mode_listener(

@async_test
async def test_interactions_with_disconnection(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server_with_disconnection(self, 3001))
t.daemon = True
t.start()
Expand Down Expand Up @@ -196,8 +191,6 @@ async def socket_mode_listener(

@async_test
async def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server(self, 3001))
t.daemon = True
t.start()
Expand Down
3 changes: 1 addition & 2 deletions tests/slack_sdk_async/socket_mode/test_interactions_websockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ def tearDown(self):

@async_test
async def test_interactions(self):
if is_ci_unstable_test_skip_enabled():
return
t = Thread(target=start_socket_mode_server(self, 3002))
t.daemon = True
t.start()
Expand Down Expand Up @@ -109,6 +107,7 @@ async def socket_mode_listener(
@async_test
async def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
# this test tends to fail on the GitHub Actions platform
return
t = Thread(target=start_socket_mode_server(self, 3001))
t.daemon = True
Expand Down