-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin moto, and support moto 5.0 changes #1463
Conversation
Thanks for the contribution! Before we can merge this, we need @s-t-e-v-e-n-k to sign the Salesforce Inc. Contributor License Agreement. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
+ Coverage 85.33% 85.41% +0.08%
==========================================
Files 111 111
Lines 12289 12289
==========================================
+ Hits 10487 10497 +10
+ Misses 1802 1792 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @s-t-e-v-e-n-k thank you for the contribution 💯 unfortunately these change would require that we drop support for python 3.6 and 3.7 which would require a major version bump and a deprecation notice
As of our latest data analysis it seem like there are still 10-15% of our developers that use python 3.6 and 3.7, since this tool is used internally by customers we try to be as generous as possible with regard to version support
If you can make these changes compatible with python 3.6 and 3.7 I will be able to approve them
72460e6
to
36fc925
Compare
@WilliamBergamin Thanks for the quick review! I've adapted my changes to support 3.6 and 3.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you 💯 requesting one change more change but then we should be good to ship
To stop testing with old versions of moto, unpin it from version 3, to the latest, depending on the Python version being used. Support both version 4 and 5 in the test suite.
36fc925
to
b0e4026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
To stop testing with old versions of moto, unpin it from version 3, to the latest, and also change the test cases to cope with the new changes.
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.