Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1446: monitor dies when exceptions raised before monitor created. #1447

Merged
merged 2 commits into from
Jan 9, 2024

fix #1446: monitor dies when exceptions raised before monitor created.

5564a24
Select commit
Loading
Failed to load commit list.
Merged

fix #1446: monitor dies when exceptions raised before monitor created. #1447

fix #1446: monitor dies when exceptions raised before monitor created.
5564a24
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2024 in 1s

85.67% (+0.06%) compared to ebdfe45

View this Pull Request on Codecov

85.67% (+0.06%) compared to ebdfe45

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ebdfe45) 85.61% compared to head (5564a24) 85.67%.

❗ Current head 5564a24 differs from pull request most recent head a387a74. Consider uploading reports for the commit a387a74 to get more accurate results

Files Patch % Lines
slack_sdk/socket_mode/aiohttp/__init__.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
+ Coverage   85.61%   85.67%   +0.06%     
==========================================
  Files         111      111              
  Lines       12128    12137       +9     
==========================================
+ Hits        10383    10398      +15     
+ Misses       1745     1739       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.