-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions.completeSuccess/Error APIs for remote functions #1432
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1432 +/- ##
==========================================
- Coverage 85.46% 85.38% -0.08%
==========================================
Files 111 111
Lines 12114 12132 +18
==========================================
+ Hits 10353 10359 +6
- Misses 1761 1773 +12 ☔ View full report in Codecov by Sentry. |
I think we can skip having codecov patch 50% this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 💯 thank you 🙇
I left one comment regarding an issue I faced during my testing of python remote functions
https://api.slack.com/methods/functions.completeSuccess | ||
""" | ||
kwargs.update({"function_execution_id": function_execution_id, "outputs": outputs}) | ||
return self.api_call("functions.completeSuccess", params=kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During my testing of python remote functions I found that passing these values to the params
parameter lead to some instability and resorted to passing values through the json
parameter to resolve the issue
This might have been an issue on my end, but could you confirm this approach is reliable for a variety of outputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin Oh, this is great catch! i totally forgot to do json.dumps()
before passing the value to kwargs. Thanks for saving me!
66e2038
to
b44f2d0
Compare
Summary
This pull request adds two endpoints, which will be coming soon, to WebClient family. Developers can use these APIs along with slackapi/bolt-python#986
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.