-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1421 Update SlackApiError exception handling for web client #1423
Conversation
Thanks for the contribution! Before we can merge this, we need @vinceta to sign the Salesforce Inc. Contributor License Agreement. |
Hi @vinceta, thanks a lot for sending this PR! Could you check the following points?
We are unable to merge your changes without signed CLA. Would you mind checking and signing it ?
the
https://github.com/slackapi/python-slack-sdk/actions/runs/6846854355/job/18614138792?pr=1423 |
@seratch Thanks for your quick response! This's my first PR, apologies for any missing. Please see if any issues still exist, thanks. |
Codecov Report
@@ Coverage Diff @@
## main #1423 +/- ##
=======================================
Coverage 85.43% 85.44%
=======================================
Files 111 111
Lines 11857 11857
=======================================
+ Hits 10130 10131 +1
+ Misses 1727 1726 -1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for fixing this!
I will work on a patch release including this change tomorrow (or at latest as early as possible this week) |
Summary
This pull request resolves #1421, also updated unit tests and README.
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.