Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-test): update traces for env to SLACK_TRACE_ENV_ #2136

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mwbrooks
Copy link
Member

Summary

This pull request updates the (unused) test traces for the env command from SLACK_TRACE_VARIABLES_ to SLACK_TRACE_ENV_.

These traces are updated because the Slack CLI has also updated it's env traces to be SLACK_TRACE_ENV_.

Requirements (place an x in each [ ])

@mwbrooks mwbrooks added semver:minor enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` labels Jan 13, 2025
@mwbrooks mwbrooks added this to the [email protected] milestone Jan 13, 2025
@mwbrooks mwbrooks requested a review from zimeg January 13, 2025 23:17
@mwbrooks mwbrooks self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (767a8a0) to head (ba12c1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2136   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          38       38           
  Lines       10320    10320           
  Branches      649      649           
=======================================
  Hits         9484     9484           
  Misses        824      824           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.24% <ø> (ø)
cli-test 94.48% <100.00%> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.82% <ø> (ø)
web-api 96.88% <ø> (ø)
webhook 96.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! It's nice that this matches the command now and super glad we can land this before #2097 is released 🙏

@mwbrooks
Copy link
Member Author

Thanks for pointing out that we haven't released #2097! It's a great opportunity to tighten up these traces before we go live.

@mwbrooks mwbrooks merged commit 6c29b1b into main Jan 14, 2025
57 checks passed
@mwbrooks mwbrooks deleted the mbrooks-cli-test-env-traces branch January 14, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants