Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use the same OkHttpClient for files.slack.com requests #1428

Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 27, 2025

This pull request resolves a bug where the files.slack.com requests fail when a developer passes OkHttpClient to SlackHttpClient when initializing the API clients to handle specific SSL conditions. This pull request tweak the internal FilesUploadV2Helper class to use the given OkHttpClient rather than creating a new once only using SlackConfig properties.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Jan 27, 2025
@seratch seratch added this to the 1.45.2 milestone Jan 27, 2025
@seratch seratch self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (c8d803a) to head (3016cd5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1428      +/-   ##
============================================
+ Coverage     73.21%   73.25%   +0.04%     
  Complexity     4377     4377              
============================================
  Files           474      474              
  Lines         14205    14206       +1     
  Branches       1437     1437              
============================================
+ Hits          10400    10407       +7     
+ Misses         2958     2951       -7     
- Partials        847      848       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 0764bd8 into slackapi:main Jan 28, 2025
6 checks passed
@seratch seratch deleted the use-same-ok-http-client-for-files.slack.com branch January 28, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants