Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated javax.servlet modules from slack-app-backend library #1412

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 8, 2025

This pull request removes the "javax.servlet-api" artifact from the slack-app-backend library. The dependency is in "provided" scope and is only used by two long-deprecated classes. Those classes will be removed too:

  • com.slack.api.app_backend.events.servlet.SlackEventsApiServlet
  • com.slack.api.app_backend.events.servlet.SlackSignatureVerifier

The primary reason why we're considering this removal this time is that having the javax.servlet dependency can be a noise for developers and admins who are examining the progress of the Jakarta Servlet migration (even though it's in "provided" scope). Initially, I was planning to remove these deprecated classes in v2, but we don't have immediate plans to release v2. Therefore, we will delete these in a minor release and clearly mention it along with the migration path in the release notes.

For context, the early version of this project was my personal project called jSlack, and we migrated it to the java-slack-sdk back in 2020. These classes have been deprecated since this project was migrated to the SlackAPI organization.

Thus, I'm sure that even several years ago, almost 100% of users were already using bolt-java modules rather than these two. There might be very few applications relying on these deprecated classes. For those users, we recommend migrating to the newer and better bolt-java modules or copying the deprecated code into their projects, as these two are quite small.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added this to the 1.45.0 milestone Jan 8, 2025
@seratch seratch self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (9b7774d) to head (0027585).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1412      +/-   ##
============================================
- Coverage     73.33%   73.26%   -0.07%     
+ Complexity     4387     4368      -19     
============================================
  Files           476      474       -2     
  Lines         14223    14172      -51     
  Branches       1434     1429       -5     
============================================
- Hits          10430    10383      -47     
- Misses         2949     2951       +2     
+ Partials        844      838       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit a21e1c4 into slackapi:main Jan 8, 2025
6 checks passed
@seratch seratch deleted the legacy-javax-servlet-dep branch January 8, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant