Remove long-deprecated javax.servlet modules from slack-app-backend library #1412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the "javax.servlet-api" artifact from the slack-app-backend library. The dependency is in "provided" scope and is only used by two long-deprecated classes. Those classes will be removed too:
The primary reason why we're considering this removal this time is that having the javax.servlet dependency can be a noise for developers and admins who are examining the progress of the Jakarta Servlet migration (even though it's in "provided" scope). Initially, I was planning to remove these deprecated classes in v2, but we don't have immediate plans to release v2. Therefore, we will delete these in a minor release and clearly mention it along with the migration path in the release notes.
For context, the early version of this project was my personal project called jSlack, and we migrated it to the java-slack-sdk back in 2020. These classes have been deprecated since this project was migrated to the SlackAPI organization.
Thus, I'm sure that even several years ago, almost 100% of users were already using bolt-java modules rather than these two. There might be very few applications relying on these deprecated classes. For those users, we recommend migrating to the newer and better bolt-java modules or copying the deprecated code into their projects, as these two are quite small.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.