Merge pull request #501 from slackapi/fix-attachment-flattening

Fix attachment flattening inside buildText
slackapi · Jul 3, 2018 · 5bad3b3 · 5bad3b3
2 parents b030cf2 + b21503e
commit 5bad3b3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/message.coffee b/src/message.coffee
@@ -91,7 +91,7 @@ class SlackTextMessage extends TextMessage
 
     # flatten any attachments into text
     if @rawMessage.attachments
-      attachment_text = @rawMessage.attachments.map(a -> a.fallback).join("\n")
+      attachment_text = @rawMessage.attachments.map((a) -> a.fallback).join("\n")
       text = text + "\n" + attachment_text
 
     # Replace links in text async to fetch user and channel info (if present)

diff --git a/test/message.coffee b/test/message.coffee
@@ -129,6 +129,17 @@ describe 'buildText()', ->
     message.buildText @client, () ->
       client.robot.logger.logs?.error.length.should.equal 1
 
+  it 'Should flatten attachments', ->
+    message = @slacktextmessage
+    client = @client
+    message.rawMessage.text = 'foo bar'
+    message.rawMessage.attachments = [
+      { fallback: 'first' },
+      { fallback: 'second' }
+    ]
+    message.buildText @client, () ->
+      message.text.should.equal 'foo bar\nfirst\nsecond'
+
 
 describe 'replaceLinks()', ->