-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slack functions with new type #237
Conversation
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 97.97% 98.07% +0.09%
==========================================
Files 58 58
Lines 2177 2280 +103
Branches 137 137
==========================================
+ Hits 2133 2236 +103
Misses 42 42
Partials 2 2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beauty! The new file ID works well in SendDM, SendMessage and ReplyInThread built-ins.
This reverts commit e165fd6.
Summary
This PR introduces the new slack type
slack#/types/file_id
and update the slack functions to use this new type.Had to also modify he generation script to improve the robustness of the generated tests
testing
https://raw.githubusercontent.com/slackapi/deno-slack-sdk/type_file_id_with_builtins/src/
as the value ofdeno-slack-sdk/
in theimport_map.json
of a projectSpecial notes
Ensure your app has the
files:read
scope, since this is required for the feature and logged error is crypticRequirements
deno task test
after making the changes.