Improve integration tests #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
approved these changes
Oct 5, 2023
| console.log("Updated functions module export"); | ||
| } | ||
|
|
||
| export const _internals = { |
There was a problem hiding this comment.
Nice! I've been wanting to try this pattern in our deno projects for a loooong time!
| import { getSlackFunctions } from "../../../../../../src/schema/slack/functions/_scripts/src/utils.ts"; | ||
|
|
||
| Deno.test(`write_function_files.ts ${_internals.main.name} function generates valid typescript`, async () => { | ||
| const getSlackFunctionsStub = mock.stub( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an integration test that ensure that the output files of the generation script are always valid typescript. The goal of this test is to ensure no breaking changes to the generation script are introduced inadvertently.
The integration tests are not included in the code coverage but will get executed by the CI pipeline.
testing
tests/integration/schema/slack/functions/_scripts/write_function_files_test.tsgets executedsrc/schema/slack/functions/_scripts/README.mdto try out the generation script and ensure everything still worksRequirements
deno task testafter making the changes.