Add files.uploadV2
#111
Add files.uploadV2
#111
Conversation
Generate files.getUploadURLExternal and files.completeUploadExternal.
and add new tests to api_test.ts.
Modify the definition of the FileUploadV2 type to extend the FileUpload type. And modify the FileUpload type so that it does not directly reference ReadableStream, ensuring npm build succeeds.
|
Thanks for the contribution! Before we can merge this, we need @racTaiga533 to sign the Salesforce Inc. Contributor License Agreement. |
|
Confirmed that we have a CLA on file for @racTaiga533 (signed 2023/12/15) - can ignore the CLA bot's complaints. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1130 1193 +63
Branches 17 27 +10
=========================================
+ Hits 1130 1193 +63 ☔ View full report in Codecov by Sentry. |
|
What's the status on this PR? I need this functionality, it would be nice if it was merged and deployed. |
|
|
|
The code provided does work but I'd probably change the API a bit. Is this moving forward? Shall/May I take over? |
This PR supersedes #90 and fixes #89. It builds upon previous work done by @taiga533; I intend to get it over the finish line.
TODO