-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JSR support #110
add JSR support #110
Conversation
refactor: better improve codebase for JSR
Thanks for the contribution! Before we can merge this, we need @lambtron @iuioiua to sign the Salesforce Inc. Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great to me, but we should look into why the integration of this PR into some of our sample apps yields typescript compilation problems 🤔
It might be how we re-mapped the deno-slack-api import in the sample project - perhaps w/ the imports now existing in deno.jsonc, the "update import map" script under scripts/
maybe needs to target deno.jsonc
instead.
Also, a million thanks for sending the PR! <3 very gracious of you
Last thing: we cannot accept the PR without the Salesforce CLA being signed by commit authors. Otherwise company lawyers will be very mad at me 😧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 36 -1
Lines 1150 1130 -20
Branches 17 17
=========================================
- Hits 1150 1130 -20 ☔ View full report in Codecov by Sentry. |
We have added a workaround fix for the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Everything passed! Going to merge shortly and we will aim to release these improvements this week sometime!
Summary
This PR includes the necessary import update to publish to JSR
Special notes
Let's discuss in Slack.
Requirements
deno task test
after making the changes.