Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JSR support #110

Merged
merged 9 commits into from
Aug 27, 2024
Merged

add JSR support #110

merged 9 commits into from
Aug 27, 2024

Conversation

lambtron
Copy link
Contributor

Summary

This PR includes the necessary import update to publish to JSR

Special notes

Let's discuss in Slack.

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@lambtron lambtron requested a review from a team as a code owner August 12, 2024 17:13
Copy link

Thanks for the contribution! Before we can merge this, we need @lambtron @iuioiua to sign the Salesforce Inc. Contributor License Agreement.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great to me, but we should look into why the integration of this PR into some of our sample apps yields typescript compilation problems 🤔

It might be how we re-mapped the deno-slack-api import in the sample project - perhaps w/ the imports now existing in deno.jsonc, the "update import map" script under scripts/ maybe needs to target deno.jsonc instead.

Also, a million thanks for sending the PR! <3 very gracious of you

Last thing: we cannot accept the PR without the Salesforce CLA being signed by commit authors. Otherwise company lawyers will be very mad at me 😧

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9105487) to head (869356b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        36    -1     
  Lines         1150      1130   -20     
  Branches        17        17           
=========================================
- Hits          1150      1130   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crowlKats
Copy link

crowlKats commented Aug 27, 2024

We have added a workaround fix for the issue.
The problem is the need of "composable importmaps", aka an importmap depending on a package that has its own importmap.
The workaround involves in copying the dependencies defined in the api importmap into the sample importmap. This can easily be fixed once things are published to JSR, as there is a dependency patching mechanism.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Everything passed! Going to merge shortly and we will aim to release these improvements this week sometime!

@filmaj filmaj merged commit 0a7a819 into slackapi:main Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants