Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include the function_executed event to bot event subscriptions #38

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: include the function_executed event to bot event subscriptions #38

merged 1 commit into from
Aug 6, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Aug 6, 2024

Type of change

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

This PR includes function_executed as a subscribed bot event to avoid manifest validation errors.

Requirements

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

@zimeg zimeg added audit Changes associated with auditing bug Something isn't working update PR only - an update or maintenance is being made to an existing app labels Aug 6, 2024
@zimeg zimeg self-assigned this Aug 6, 2024
misscoded
misscoded approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇🏼‍♀️

@zimeg
Copy link
Member Author

zimeg commented Aug 6, 2024

@misscoded likewise 🙏

@zimeg zimeg merged commit 3d28a65 into main Aug 6, 2024
3 checks passed
@zimeg zimeg deleted the zimeg-fix-manifest-event-subscription branch August 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misscoded misscoded misscoded approved these changes

@WilliamBergamin WilliamBergamin Awaiting requested review from WilliamBergamin

@srajiang srajiang Awaiting requested review from srajiang

Assignees

@zimeg zimeg

Labels
audit Changes associated with auditing bug Something isn't working update PR only - an update or maintenance is being made to an existing app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @misscoded